Going from one fragment to another fragment savedInstanceState not working

Question

Good day, I have a navigation drawer activity. Inside those are fragments. I tried using the onSavedInstanceState by changing the orientation. And yes it is working. But when i go from one fragment to another. It is not being called. Please help. The specific thing that i need to do is to save the recipients list when going back to this fragment. Thank you so much in advance. Here's my code:

 @Override
public void onCreate(@Nullable Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
}

@Override
public View onCreateView(LayoutInflater inflater,  @Nullable ViewGroup container,
                         @Nullable Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.fragment_recipients,container,false);
    if(savedInstanceState!=null){
        System.out.println("savedInstanceState Called!");
        saved_recipients = savedInstanceState.getStringArrayList("recipients");
        System.out.println(saved_recipients);
    }
    else{
        System.out.println("savedInstanceState not called!");
        button = (Button) view.findViewById(R.id.button);
        recipients = new ArrayList<String>();
        recipients_backend = new ArrayList<String>();
        container_recipients = (ListView) view.findViewById(R.id.listView);
        arrayAdpt= new ArrayAdapter<String>(getActivity(),
                android.R.layout.simple_list_item_1, recipients);
        container_recipients.setAdapter(arrayAdpt);
        button.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent = new Intent(Intent.ACTION_PICK, ContactsContract.Contacts.CONTENT_URI);
                startActivityForResult(intent, PICK_CONTACT);
            }
        });
    }
    return view;
}


@Override
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);
}

@Override
public void onActivityResult(int reqCode, int resultCode, Intent data) {
    super.onActivityResult(reqCode, resultCode, data);

    switch (reqCode) {
        case (PICK_CONTACT) :
            if (resultCode == Activity.RESULT_OK) {
                String cNumber = null;
                Uri contactData = data.getData();
                Cursor c =  getActivity().managedQuery(contactData, null, null, null, null);
                if (c.moveToFirst()) {


                    String id =c.getString(c.getColumnIndexOrThrow(ContactsContract.Contacts._ID));


                    String hasPhone =c.getString(c.getColumnIndex(ContactsContract.Contacts.HAS_PHONE_NUMBER));

                    if (hasPhone.equalsIgnoreCase("1")) {
                        Cursor phones = getActivity().getContentResolver().query(
                                ContactsContract.CommonDataKinds.Phone.CONTENT_URI,null,
                                ContactsContract.CommonDataKinds.Phone.CONTACT_ID +" = "+ id,
                                null, null);
                        phones.moveToFirst();
                        cNumber = phones.getString(phones.getColumnIndex("data1"));

                    }
                    String name = c.getString(c.getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
                    recipients.add(name + "   " + cNumber);
                    System.out.println("New recipient added! Current list of recipients:  " + recipients);
                    if (!(recipients.isEmpty())){
                        //button.setVisibility(View.INVISIBLE);


                    }
                    else
                        // button.setVisibility(View.VISIBLE);
                        recipients_backend.add(cNumber);
                    arrayAdpt.notifyDataSetChanged();
                    System.out.println(recipients_backend);

                }
            }
            break;
    }
}
@Override
public void onSaveInstanceState(Bundle outState){
    super.onSaveInstanceState(outState);
    outState.putStringArrayList("recipients",recipients);


}

score 0 · Answer 1 · edited May 23 '17 at 12:10

0

onSavedInstanceState is called when your fragments lifecycle is interrupted, not when it finishes normally.

You should use one of onPause, onStop or onDetach instead.

As the system doesn't know you plan to instantiate a new instance of your fragment, you need to save somewhere else, e.g. in SharedPreferences:

Get:

saved_recipients = new ArrayList(sharedPreferences.getStringSet("recipients"));

Set:

@Override
public void onPause(){
    sharedPreferences.edit().putStringSet("recipients",new HashSet(recipients)).apply();
}

If you do not want to save this data permanently, but only as long as the activity lives, store it in the activity itself. For Fragment-Activity-communication see Communicating between a fragment and an activity - best practices.

edited May 23 '17 at 12:10

Community

1
1

answered May 16 '17 at 16:52

F43nd1r

7,690
3
24
62

Hello, @F43nd1r. First of all i want to thank you for responding to my post. Can you please give me a sample code on how do i do it? Thank you so much! – NewbieProgrammer May 16 '17 at 16:58
Edited with additional info – F43nd1r May 16 '17 at 22:24
Hello, F43nd1r. Im sorry if it took a while for me to respond back to your post. Let me try this. Also, where should i put the saved_recipients = new ArrayList? – NewbieProgrammer May 18 '17 at 14:17
Also @F43nd1r. Im having an error in sharedPrefrences.edit so on and so forth. Says cannot resolve symbol. – NewbieProgrammer May 18 '17 at 14:27
You have to set a field with your shared preferences. For default use PreferenceManager.getDefaultSharedPreferences(this) – F43nd1r May 18 '17 at 14:38
Hello, @F43nd1r. Thank you for your respond. I'm not getting what you mean because im really a newbie on android. – NewbieProgrammer May 18 '17 at 14:49
I've added the needed changes to your code. I Don't want to spam the answer, so I've hosted it here http://freetexthost.com/txarsy5riw – F43nd1r May 18 '17 at 15:43

Going from one fragment to another fragment savedInstanceState not working

1 Answers1