Static ArrayList between Fragments

Question

I have a static ArrayList defined in my activity, being used by several fragments within it. This ArrayList is sometimes modified.

Is this bad practice? Should I be using bundles/SQLite instead?

score 3 · Answer 1 · answered Jun 28 '17 at 16:07

Yes static is always bad (you should avoid it whenever possible), because even if you dont have access to the Activity instance you can modify it like this SomeActivitiy.list.removeAll(); for example.

What I would suggest it the use of a DataProvider that contains your data and you just have to inject it in your fragments.

The SQLite option in the other hand should only be used when you have to persist the data, so you don't have to delete after using it.

I'll start looking into DataProviders now, thanks for the information! — Adam Arcaro, Jun 28 '17 at 16:09

score 1 · Answer 2 · answered Jun 28 '17 at 17:05

1

Consider using public field ArrayList and your fragments can use or modify it easily.

But, please read this first. Public field or Getter/Setter

answered Jun 28 '17 at 17:05

phatnhse

3,870
2
20
29

Didnt even consider this... Seems far simpler. I'll look into it now, thanks – Adam Arcaro Jun 28 '17 at 18:02

Static ArrayList between Fragments

2 Answers2