36

I'm having an issue with my app when testing for iPhone X. I'm not sure how to adjust this issue, as well as not make it an issue for non iPhone X sizes. This only seems to be an issue on the iPhone X simulator.

enter image description here

enter image description here

Nishant Bhindi
  • 2,242
  • 8
  • 21
icekomo
  • 9,328
  • 7
  • 31
  • 59
  • use programmatically TabbarController which will not affect this issues – Hitesh Nov 01 '17 at 12:36
  • 1
    Did you resolved this problem.I am facing this issue because of custom tabbar height – Shangari C Apr 13 '18 at 05:04
  • @ShangariC Your issue is same as mine (custom height), and you can try [this](https://gist.github.com/calt/7ea29a65b440c2aa8a1a#gistcomment-2270140), remove the `viewWillLayoutSubviews`'s override, and use this instead to apply custom height. – Dan Dec 27 '18 at 14:42
  • Check this: https://stackoverflow.com/a/61958194/2802706 – Saeid May 22 '20 at 15:15

20 Answers20

17

On iOS 12.1 I've solved this issue by overriding safeAreaInsets in the UITabBar subclass:

class TabBar: UITabBar {
    private var cachedSafeAreaInsets = UIEdgeInsets.zero

    override var safeAreaInsets: UIEdgeInsets {
        let insets = super.safeAreaInsets
    
        if insets.bottom < bounds.height {
            cachedSafeAreaInsets = insets
        }
    
        return cachedSafeAreaInsets
    }
}

For iOS 13.0 onward,

class TabBar: UITabBar {
    private var cachedSafeAreaInsets = UIEdgeInsets.zero

    let keyWindow = UIApplication.shared.connectedScenes
        .filter { $0.activationState == .foregroundActive }
        .compactMap { $0 as? UIWindowScene }
        .first?.windows
        .filter { $0.isKeyWindow }
        .first
    
    override var safeAreaInsets: UIEdgeInsets {
        if let insets = keyWindow?.safeAreaInsets {
            if insets.bottom < bounds.height {
                cachedSafeAreaInsets = insets
            }
        }
        return cachedSafeAreaInsets
    }
}
Andrey
  • 521
  • 6
  • 9
15

Create a separate file with the following code:

extension UITabBar {
    override open func sizeThatFits(_ size: CGSize) -> CGSize {
        super.sizeThatFits(size)
        guard let window = UIApplication.shared.keyWindow else {
            return super.sizeThatFits(size)
        }
        var sizeThatFits = super.sizeThatFits(size)
        sizeThatFits.height = window.safeAreaInsets.bottom + 40
        return sizeThatFits
    }
}
Renetik
  • 5,887
  • 1
  • 47
  • 66
Mohamed Ali
  • 263
  • 3
  • 13
10

"File inspector"

"File inspector" from right of Xcode storyboard, enable Safe Area guide layout to support your app in iPhone

This post describes it really well.

shim
  • 9,289
  • 12
  • 69
  • 108
Dipak Kacha
  • 423
  • 2
  • 13
7

For iOS 11.3 this worked for me:

func viewDidLayoutSubviews() {
    super.viewDidLayoutSubviews()
    tabBar.invalidateIntrinsicContentSize()
}
clopex
  • 459
  • 6
  • 11
3

In Constraints -

If you are giving bottom space with "Bottom Layout Guide", then this issue will occur.

Solution:

Give bottom space with respect to superview. This will work 100% perfect.

Mehul Thakkar
  • 12,440
  • 10
  • 52
  • 81
3

This worked for me.

[self.tabBar.bottomAnchor constraintEqualToAnchor:self.view.layoutMarginsGuide.bottomAnchor].active = YES;
steveSarsawa
  • 1,559
  • 2
  • 14
  • 31
Jonah
  • 4,810
  • 14
  • 63
  • 76
2

I had a a similar issue. I was setting the selectionIndicatorImage in viewDidLoad(). Moving the code to viewDidLayoutSubviews() fixed my issue.

Randeep
  • 403
  • 1
  • 4
  • 11
2

Just align the bottom of the UITabBar to the superview, not to the safe area. If you align it to safe area it will be like this:

Align to safe area

And when aligned to the superview, it will show correctly:

Align to Superview

I think this is because Apple gave the tab bar items a default margin to the bottom if it is on iPhone X as they want the tab bar to be extended to the bottom of the screen to avoid a floating bar.

ben87nz
  • 79
  • 7
2

Follow below guidelines for setting the UITabbar selectionIndicatorImage.

  1. UITabBar.appearance().selectionIndicatorImage = #YOUR_IMAGE
  2. Make sure your image height is 48.

The default height of tabbar selectionIndicatorImage is 49, But in iPhone X set image height equals to 48.

1

The solution for me was that I had a custom UITabBar height set, something like this:

  override func viewWillLayoutSubviews() {            
        var tabFrame = tabBar.frame
        tabFrame.size.height = 60
        tabFrame.origin.y = self.view.frame.size.height - 60
        tabBar.frame = tabFrame
    }

Remove it and the tab bar will display correctly on iPhone X.

Gytis
  • 670
  • 6
  • 19
1

Add this code in viewDidLoad

DispatchQueue.main.async {
            let size = CGSize(width: self.tabBar.frame.width / numberOfTabsFloat,
                              height: self.tabBar.frame.height)
            let image = UIImage.drawTabBarIndicator(color: UIColor.white,
                                                   size: size,
                                                   onTop: false)
            UITabBar.appearance().selectionIndicatorImage = image
            self.tabBar.selectionIndicatorImage = image
        }

and add this extension

extension UIImage{
    //Draws the top indicator by making image with filling color
    class func drawTabBarIndicator(color: UIColor, size: CGSize, onTop: Bool) -> UIImage {
        let indicatorHeight = size.height
        let yPosition = onTop ? 0 : (size.height - indicatorHeight)

        UIGraphicsBeginImageContextWithOptions(size, false, 0)
        color.setFill()
        UIRectFill(CGRect(x: 0, y: yPosition, width: size.width, height: indicatorHeight))
        let image = UIGraphicsGetImageFromCurrentImageContext()
        UIGraphicsEndImageContext()

        return image!
    }
}
1

Put this into your UITabBarViewController to correct the TabBar height if your UIViewController is rotatable.

override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
        super.viewWillTransition(to: size, with: coordinator)
        tabBar.sizeToFit()
    }
cpt.blood
  • 21
  • 2
0

invalidateIntrinsicContentSize of UITabBar in viewWillLayoutSubviews that may help you.

 override func viewWillLayoutSubviews() {
    super.viewWillLayoutSubviews()
    self.tabBar.invalidateIntrinsicContentSize()
}
Nishant Bhindi
  • 2,242
  • 8
  • 21
0

This worked for me as I am using a selection image.

tabBar.selectionIndicatorImage = UIImage.imageWithColor(color: UIColor.NewDesignColor.yellow, size: tabBarItemSize).resizableImage(withCapInsets: UIEdgeInsets.init(top: 0, left: 0, bottom: 20, right: 0))

Adding a bottom inset helps in my case. Hope this works for your as well. Thanks.

shim
  • 9,289
  • 12
  • 69
  • 108
Akanksha Sharma
  • 131
  • 1
  • 10
0

There is UITabBar subclass that solves all my issues with iPhone X iOS 11 / iOS 12

class TabBar: UITabBar {

private var _safeAreaInsets = UIEdgeInsets.zero
private var _subviewsFrames: [CGRect] = []

@available(iOS 11.0, *)
override func safeAreaInsetsDidChange() {
    super.safeAreaInsetsDidChange()

    if _safeAreaInsets != safeAreaInsets {
        _safeAreaInsets = safeAreaInsets

        invalidateIntrinsicContentSize()
        superview?.setNeedsLayout()
        superview?.layoutSubviews()
    }
}

override func sizeThatFits(_ size: CGSize) -> CGSize {
    var size = super.sizeThatFits(size)
    if #available(iOS 12.0, *) {
        let bottomInset = safeAreaInsets.bottom
        if bottomInset > 0 && size.height < 50 && (size.height + bottomInset < 90) {
            size.height += bottomInset
        }
    }
    return size
}

override var frame: CGRect {
    get {
        return super.frame
    }
    set {
        var tmp = newValue
        if let superview = superview, tmp.maxY !=
                superview.frame.height {
            tmp.origin.y = superview.frame.height - tmp.height
        }

        super.frame = tmp
    }
}

override func layoutSubviews() {
    super.layoutSubviews()
    let state = subviews.map { $0.frame }
    if (state.first { $0.width == 0 } == nil) {
        _subviewsFrames = state
    } else {
        zip(subviews, _subviewsFrames).forEach { (view, rect) in
            view.frame = rect
        }
    }

}
}
Maxime Ashurov
  • 559
  • 4
  • 11
0

Apple has now fixed this issue in iOS 12.1.1

0

It's look crazy but I just need to remove this line in my code

self.view.layoutIfNeeded()

I just guess that call layoutIfNeeded on a view that doesn't appear in screen will make this problem happen. Anyway, solution from @mohamed-ali also work correctly. Thanks you so much.

Hiro
  • 391
  • 5
  • 10
0

Although my answer is late, But let me ensure you, if you are facing any issue like this on iphone x, xs or max screen, Make sure the image size you are uploading as selection must have height = width * 48pxHeight.

Raza.najam
  • 769
  • 6
  • 15
0

After trying a few solutions, what worked for me was adding the following line to viewDidLoad:

[self.tabBar.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor].active = YES;

Jonah's and Mehul Thakkar's answers pointed me in the right direction.

Note: I only had a blank tab bar controller in storyboard. The tab bar images and view controllers were setup using the tabBarItem properties (e.g., tabBarItem.title on the view controllers).

ipje
  • 161
  • 1
  • 7
-1

I was facing this cosmetic problem above iOS 11.0 and below 12.0 only.

enter image description here

I was having a CustomTabBar class inherited from UITabBar. I override the frame method like below:

- (CGRect)frame{
    return self.bounds;
}

It resolved this issue in most of the iOS version 11.0 *

Prabhat Kasera
  • 1,129
  • 11
  • 28