Compiler is complaining that cell is nil when I try to get indexpath.row when button is tapped on cell

Question

Here is my code.

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
    let cell: CellAvailableJobs = self.tblJobs.dequeueReusableCell(withIdentifier: "CellAvailableJobs") as! CellAvailableJobs
    let jobsNearByObj:JobsNearBy = self.jobsArray![indexPath.row]
    cell.loadCell(jobsNearByObj: jobsNearByObj)
    cell.btnHeart.addTarget(self, action: #selector(JobsVC.btnBookmarkAction), for: .touchUpInside)
    cell.btnHeart.tag = indexPath.row
    return cell
}

@IBAction func btnBookmarkAction(_ sender: AnyObject){
    let button = sender as? UIButton
    print("tag: \(String(describing: button?.tag))")
    let cell = button?.superview?.superview as? UITableViewCell
    let indexPath = tblJobs.indexPath(for: cell!)
    print("bookmarkedJobId: \(String(describing: indexPath.row))")
}

I'm fetching data from web and populating them on tableview, everything is working well. I want to print indexpath.row when the button on cell is tapped. On above method the compiler is complaining that the cell is nil. This line: let indexPath = tblJobs.indexPath(for: cell!).

What is the problem with this code. How the cell is nil in this code. Can anyone help me with this issue?

The _compiler_ knows nothing of the cell being `nil`. The problem occurs at runtime. — matt, Feb 08 '18 at 14:34
@Matt ok thank you. there was another view on hierarchy. I forgot that. :) let cell = button?.superview?.superview?.superview as! UITableViewCell ...this line works — Sptibo, Feb 08 '18 at 14:46
@Sptibo Don't navigate the cell view hierarchy. It is fragile. Don't use tags. They are fragile. Engineer a proper solution. https://stackoverflow.com/questions/28659845/swift-how-to-get-the-indexpath-row-when-a-button-in-a-cell-is-tapped/38941510#38941510 — Paulw11, Feb 08 '18 at 19:48

Shehata Gamal · Answer 1 · 2018-02-08T14:38:08.283

0

The problem is when cell is currently not visible it's value is nil , you can't explicitly unwrap an optional value

let cell = button?.superview?.superview as? UITableViewCell

Try this

 if(cell != nil)
{
   let indexPath = tblJobs.indexPath(for: cell!)
}

beside type of cell is CellAvailableJobs and you use as? UITableViewCell

edited Feb 08 '18 at 14:38

answered Feb 08 '18 at 14:31

Shehata Gamal

98,760
8
65
87

@ Sh_Khan But it is crashing when i tap on cell button. That means cell is visible. Or not? – Sptibo Feb 08 '18 at 14:33
cell is nil. I've applied guard let statement also..it prevents the app from crash but I am unable to get indexpath.row – Sptibo Feb 08 '18 at 14:38
where do you add it ?? above the table ? – Shehata Gamal Feb 08 '18 at 14:42

Milan Nosáľ · Answer 2 · 2018-02-08T23:22:49.717

0

Line let cell = button?.superview?.superview as? UITableViewCell seems to fail to be the UITableViewCell instance, thus cell is nil.

As you figured out, this is what you wanted in fact:

let cell = button?.superview?.superview?.superview as? UITableViewCell

edited Feb 08 '18 at 23:22

answered Feb 08 '18 at 14:33

Milan Nosáľ

19,169
4
55
90

@Sptibo show your hierarchy how you add button to the cell – Milan Nosáľ Feb 08 '18 at 14:41

Compiler is complaining that cell is nil when I try to get indexpath.row when button is tapped on cell

2 Answers2