Closing nested Reader

Question

When reading from a text file, one typically creates a FileReader and then nests that in a BufferedReader. Which of the two readers should I close when I'm done reading? Does it matter?

FileReader fr = null;
BufferedReader br = null;
try
{
    fr = new FileReader(fileName);
    br = new BufferedReader(fr);
    // ...
}
finally
{
    // should I close fr or br here?
}

I'm a little paranoid when it comes to exception-safety. What happens when the BufferedReader constructor throws an exception? Does it close the nested reader? Or is it guaranteed not to throw?

McDowell · Accepted Answer · 2012-11-14T22:46:22.037

10

Generally, close() on the outermost stream wrapper will call close() on the wrapped streams. However, if you think it's likely that a constructor will throw an exception, make liberal use of the Closeable interface.

FileReader fr = new FileReader(fileName);
Closeable res = fr;
try {
    BufferedReader br = new BufferedReader(fr);
    res = br;
} finally {
    res.close();
}

So, even if the JVM ran out of heap space for the buffer and threw an error, you wouldn't leak a file handle.

For Java 7 and above use try-with-resources:

try (FileReader fr = new FileReader(fileName);
    BufferedReader br = new BufferedReader(fr)) {
  // do work
}

edited Nov 14 '12 at 22:46

answered Feb 05 '11 at 19:37

McDowell

107,573
31
204
267

Good solution if you're working with multiple possibly exception-throwing wrappers (and similar). Of course, you could check the documentation and code of the `BufferedReader` to see if there's actually any chance of an exception in the ctor. – cthulhu Feb 05 '11 at 21:37

score 1 · Answer 2 · answered Feb 05 '11 at 19:30

1

Closing only the BufferedReader is enough, cause it wraps the FileReader. If you look at the source code of BufferedReader you will see that the close method, closes the wrapped stream.

answered Feb 05 '11 at 19:30

Petar Minchev

46,889
11
103
119

score 0 · Answer 3 · answered Feb 05 '11 at 19:31

0

Close the BufferedReader in a finally block.

answered Feb 05 '11 at 19:31

duffymo

305,152
44
369
561

score 0 · Answer 4 · answered Feb 05 '11 at 19:38

If you call the BufferedReader's close method, the BufferedReader will call the FileReader's close method. Thus both close method's are called. More precisely the BufferedReader will do nothing BUT calling the FileReader's close method. Thus it does not matter at all. Though I think it is good practice too call the BufferedReader's close method.

score 0 · Answer 5 · answered Feb 05 '11 at 21:00

Nothing is guaranteed not to throw. Because the buffer is allocated it may throw OutOfMemoryError. I usually separate my code into 2 sections: acquire resources and then use resources. Each section usually has unique cleanup needs

Here is the code to illustrate:

// Acquire resources section.

final FileReader fr = new FileReader( fileName );

BufferedReader br = null;

try
{
    br = new BufferedReader(fr);
}
finally
{
    if ( br == null )
    {
        // Note that you are closing the fr here
        fr.close( );
    }
}

// Use resources section
try
{
    // ... use br
}
finally
{
    // Now that br is safely constructed, just all its close
    br.close( );
}

And I agree with you, there is nothing worth than silently loose a file handler in the long running server application.

Closing nested Reader

5 Answers5