.getImage() on a null object reference android

Question

I have a fragment. After click on image i strart activity. But i keep getting this error

Unable to start activity ComponentInfo{com.flag.app/com.flag.app.app.activity.MarkerDetailsActivity}:
java.lang.NullPointerException: Attempt to invoke virtual method 'com.flag.app.app.model.Image com.flag.app.app.model.Marker.getImage()' 
on a null object reference

So, this is my activity

public class MarkerDetailsActivity extends AppCompatActivity {

public static Intent getStartIntent(Context context, Marker marker) {
    Intent startIntent = new Intent(context, MarkerDetailsActivity.class);
    startIntent.putExtra(EXTRA_MARKER, marker);
    return startIntent;
}


ImageView mImageView;
TextView mNameTextView;
Marker mMarker;
MapView mMapView;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_details_marker);
    mMarker = getIntent().getParcelableExtra(EXTRA_MARKER);

    mImageView = findViewById(R.id.image_view);
    mMapView = findViewById(R.id.map_view);
    mMapView.onCreate(savedInstanceState);
    bindMarker(mMarker);
}

private void bindMarker(Marker marker) {
    Picasso.with(mImageView.getContext())
            .load(marker.getImage().getUrl())
            .into(mImageView);
    mAuthorTextView.setText(marker.getAuthor());
    mDescriptionTextView.setText(marker.getDescription());
    mDateTextView.setText(marker.getDate());

}
   }

How to fix it?

How do you know `getParcelableExtra` actually returned a value? — OneCricketeer, Jul 24 '18 at 04:32
getParcelableExtra actually didn`t returned a value? How to fix it? — Max Yablonskyi, Jul 24 '18 at 04:59
Is that a question or a verification? You need to show how you are using getStartIntent method — OneCricketeer, Jul 24 '18 at 05:00

score 0 · Answer 1 · answered Jul 24 '18 at 04:37

0

Check for null value.

private void bindMarker(Marker marker) {
if(marker != null){
    Picasso.with(mImageView.getContext())
            .load(marker.getImage().getUrl())
            .into(mImageView);
    mAuthorTextView.setText(marker.getAuthor());
    mDescriptionTextView.setText(marker.getDescription());
    mDateTextView.setText(marker.getDate());

}}

answered Jul 24 '18 at 04:37

Arvind

444
4
14

1

The image of the marker could still be null – OneCricketeer Jul 24 '18 at 05:01

score 0 · Answer 2 · answered Jul 24 '18 at 04:38

private void bindMarker(Marker marker) {
    if(marker!=null){
        if(marker.getImage()!=null) {
            Picasso.with(mImageView.getContext())
                    .load(marker.getImage().getUrl())
                    .into(mImageView);
        }
        mAuthorTextView.setText(marker.getAuthor());
        mDescriptionTextView.setText(marker.getDescription());
        mDateTextView.setText(marker.getDate());
    }
}

you have to check before using Marker object is null or not

.getImage() on a null object reference android

2 Answers2