Call $http inside AngularJS function

Question

I've been trying for a while to get the data from this call, but it always returns "undefined"

httpCall = function(sTformName) {
  let sURL = "https://urlthisone/api/",
  response; 

  $http.get(sURL)
    .success(function(data) {
      response = data;
    });
}

Any ideas on what I'm doing wrong? Thanks in advance.

When a JavaScript function lacks a [return statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/return) it returns `undefined`. That's the way JavaScript works. — georgeawg, Sep 15 '18 at 05:16
Was my answer below able to help you out here? Please let me know. I'd like to help you resolve this one. — scniro, Sep 17 '18 at 13:05

scniro · Accepted Answer · 2018-09-14T20:30:55.777

3

You can return and resolve the promise...

httpCall = function(sTformName) {
  let sURL = 'https://urlthisone/api/',
  return $http.get(sURL);
}

httpCall('myForm').then(response => {
  console.log(response.data);
});

$http.get is an asynchronous call and must be handled accordingly, in this case, by resolving the returned Promise

edited Sep 14 '18 at 20:30

answered Sep 14 '18 at 20:25

scniro

16,844
8
62
106

Why 'myForm'? Where does that come from? – Jose Peres Sep 17 '18 at 16:40
It's just an example, since your function `httpCall` takes a parameter named `sTformName`. I'd imagine this means something to you... – scniro Sep 17 '18 at 16:57
Yes, sorry. This one did the trick! Hadn't been able to answer until now. Thanks! – Jose Peres Sep 20 '18 at 15:44
happy to hear :) – scniro Sep 20 '18 at 19:16

score 0 · Answer 2 · answered Sep 14 '18 at 20:32

0

You're making an async call, and it will not return a value. It calls success and inside success you need to use a callback method in order to get the value you want, and work with it.

function doSomethingWithTheData(data) {
  // process the data here.
}

httpCall = function(sTformName, callback) {
    let sURL = "https://urlthisone/api/",
    response; 

    $http.get(sURL)
        .success(function(data) {
        callback(data); // here's where we call the callback
    });
}

// call it with the callback
httpCall(fornName, doSomethingWithTheData);

answered Sep 14 '18 at 20:32

nixkuroi

2,259
1
19
25

The `.success` method is [deprecated and removed from version 1.6](https://stackoverflow.com/questions/35329384/why-are-angularjs-http-success-error-methods-deprecated-removed-from-v1-6/35331339#35331339). – georgeawg Sep 15 '18 at 05:11
Also see [Why are Callbacks from Promise `.then` Methods an Anti-Pattern](https://stackoverflow.com/questions/35660881/why-are-callbacks-from-promise-then-methods-an-anti-pattern). – georgeawg Sep 15 '18 at 05:12
@georgeawg His initial example uses .success, so I was providing an answer that applied to his question. Please do not down vote answers that both work, and pertain directly to the question asked. – nixkuroi Sep 17 '18 at 00:28

score 0 · Answer 3 · edited Sep 15 '18 at 05:08

0

Please, see documentation - https://docs.angularjs.org/api/ng/service/$http#get

According to it, if you use angular.js 1.4.3+, $http.get(sURL) returns promise. So you need $http.get(sURL).then(...) Also, see $http.get(...).success is not a function might will help

edited Sep 15 '18 at 05:08

georgeawg

48,608
13
72
95

answered Sep 14 '18 at 21:38

dsych

754
7
13

1

The .success syntax was correct up to Angular v1.4.3 - so it depends on what version you're using. – nixkuroi Sep 14 '18 at 21:48
@nixkuroi The `.success` method should be avoided even with older versions of AngularJS. – georgeawg Sep 15 '18 at 05:21

Call $http inside AngularJS function

3 Answers3