onActivityResult never called

Question

So far, I used the startActivity function with success and now that I need to use the startActivityResult, I have a problem.

When using this function, the activity I expect to be launched is launched correctly but it seems like the onActivityResult function is never called.

Here is my code in the FriendPicker activity, to lauch the MoodPicker activity:

Intent intent = new Intent(FriendPicker.this, MoodPicker.class);
startActivityForResult(intent, 2);

And here is my code in the MoodPicker activity:

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent intent)
{                   
    super.onActivityResult(requestCode, resultCode, intent);

    Log.i("in OnActivityResult", "Activity Result");                        

    switch (requestCode)
    {
        case 2:             
            Log.i("in OnActivityResult", "Activity Resut 2");                

            break;
    }
}

and nothing in my logfile is written (I of course, checked that my log file was working properly and double check with a text view output).

Is there something I forgot to declare in the Manifest file?

Thanks in advance.

score 28 · Answer 1 · answered Dec 28 '11 at 11:43

28

I had same problem and solved it: Just remove

android:launchMode="singleInstance"

answered Dec 28 '11 at 11:43

ranjeet wagh

306
3
2

This issue was driving me crazy, well spotted – German Jan 21 '14 at 21:10
Just wasted a few hours on this. Lifesaver right here. – Maurizio Aug 29 '14 at 04:54
ohhh really very very thanks. i waste my 5 hour for this and finally got it with your solution. – Ajay Bhayani Mar 16 '16 at 07:51

score 23 · Answer 2 · answered Feb 08 '13 at 14:02

23

In my case, I didn't realize I was calling startActivityForResult from an activity that had the android:noHistory attribute set to true in the manifest. Therefore, the onActivityResult was never called as there was no activity instance anymore.

answered Feb 08 '13 at 14:02

Xavi Gil

11,460
4
56
71

5

I was stuck with this problem for hours. Then I saw your answer and realized I had made the same mistake. Thanks for this answer! – Shubham Mar 02 '13 at 00:27
YES. Thank you so much. – Antoine Feb 12 '16 at 15:19

score 10 · Accepted Answer · answered Mar 14 '11 at 17:32

10

Did you add the setResult() call in your MoodPicker class ?

answered Mar 14 '11 at 17:32

Kevin Gaudin

9,927
3
32
34

12

Please add your solution so that other users reading this post can find useful help. – Kevin Gaudin Mar 16 '11 at 16:59

score 9 · Answer 4 · answered Dec 03 '14 at 03:50

9

android:noHistory="true"

like

android:launchMode="singleInstance"

will stop onActivityResult from receive result.

answered Dec 03 '14 at 03:50

Nick Jian

457
4
12

android:launchMode="singleTask" poses the same issue. – geecko May 05 '15 at 18:59

score 6 · Answer 5 · edited Mar 14 '11 at 21:30

6

If I am reading this right, all the code referenced needs to be in "FriendPicker". In "MoodPicker" you need code like this that sets the result and ends itself:

this.setResult(SUCCESS_RETURN_CODE, i);
this.finish();

Let me know if this helps...

edited Mar 14 '11 at 21:30

Lumis

21,517
8
63
67

answered Mar 14 '11 at 17:40

eyespyus

1,576
19
20

You mean that all the code I wrote should be in the FriendPicker activity? Cause if it is so, there is something I don't get at all in the startActivityForResult process. – thomaus Mar 14 '11 at 17:48
I tried putting the onActivityResult function in my FriendPicker class and lo log either. I don't get it... – thomaus Mar 14 '11 at 18:18
3

onActivityResult() should be placed in the Activity where you called startActivityForResult() – Kevin Gaudin Mar 14 '11 at 19:37

score 6 · Answer 6 · edited Oct 08 '12 at 15:26

6

There is bug in android API. In startActivityForResult(intent, requestCode); This funktion does work as long as requestCode = 0. However, if you change the request code to anything other than zero, the ApiDemos will fail (and OnActivityResult won't be called). Found here:

[EDIT: Link removed as google group overrun with spam]

edited Oct 08 '12 at 15:26

Ben Clayton

80,996
26
120
129

answered Oct 24 '11 at 19:08

insomniac

379
5
7

2

Actually it will work with any requestCode >= 0. Anything negative however doesn't. – whitebrow Apr 08 '13 at 15:43
THANKS!! by mistake I was sending a -1 and the instruction works (I meen it opens the Activity) but then it does not receive data, so you have to add a code >= 0 – Stornu2 Jun 03 '15 at 07:06

score 3 · Answer 7 · edited May 23 '17 at 10:32

FriendPicker activity

Intent intent = new Intent(FriendPicker.this, MoodPicker.class);
startActivityForResult(intent, 2);


@Override
protected void onActivityResult(int requestCode, int resultCode, Intent intent)
{                   
    super.onActivityResult(requestCode, resultCode, intent);

    Log.i("in OnActivityResult", "Activity Result");                        

    switch (requestCode)
    {
        case 2:             
             if (resultCode == Activity.RESULT_OK) {     //optional   
            Log.i("in OnActivityResult", "Activity Resut 2");                
              }
            break;
    }
}

MoodPicker class

Intent intent = new Intent(MoodPicker.this, FriendPicker.class);
        setResult(Activity.RESULT_OK, intent);
finish();

I had the same problem using onActivityResult(); cause i didn´t understand how this will be correctly applied, here you can find a good explanation how to use onActivityResult onActivityResult doesn't work?

score 0 · Answer 8 · answered Sep 28 '15 at 03:50

0

The mistake that I had made was that after creating my Intent I was calling startActivity() instead of startActivityForResult()

Sometimes the simple ones kill you :)

answered Sep 28 '15 at 03:50

msimons

495
10
19

score 0 · Answer 9 · answered Sep 10 '18 at 09:48

0

My silly mistake. Might help someone.

I kept onActivityResult(...) in another class. It has to be as a method in the class where the startActivityForResult() is called.

answered Sep 10 '18 at 09:48

Shachi

1,858
3
23
41

score 0 · Answer 10 · answered Mar 26 '21 at 10:14

In case you're wondering about this in react-native in a native module:

in your MainActivity:

...
private ReactInstanceManager mReactInstanceManager;
...
@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);

    mReactInstanceManager.onActivityResult(requestCode, resultCode, data);
}

in your Module:

public class MyModule extends ReactContextBaseJavaModule implements ActivityEventListener {
    static final int REQUEST_VIDEO_CAPTURE = 1;

    final ReactApplicationContext reactContext;
    Promise promise;

    public GeneralIntentModule(ReactApplicationContext reactContext) {
        super(reactContext);
        this.reactContext = reactContext;
        this.reactContext.addActivityEventListener(this);
    }

    @Override
    public String getName() {
        return "MyModule ";
    }

    @ReactMethod
    public void captureVideo(Promise promise) {
        this.promise = promise;
        Intent takeVideoIntent = new Intent(MediaStore.ACTION_VIDEO_CAPTURE);
        if (takeVideoIntent.resolveActivity(this.reactContext.getPackageManager()) != null) {
            this.reactContext.startActivityForResult(takeVideoIntent, REQUEST_VIDEO_CAPTURE, null);
        }
    }

    @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
        this.promise.resolve(data.getDataString());
    }
}

onActivityResult never called

10 Answers10

Linked