51

The following code is generating a stack overflow error for me

int main(int argc, char* argv[])
{
    int sieve[2000000];
    return 0;
}

How do I get around this? I am using Turbo C++ but would like to keep my code in C

EDIT:

Thanks for the advice. The code above was only for example, I actually declare the array in a function and not in sub main. Also, I needed the array to be initialized to zeros, so when I googled malloc, I discovered that calloc was perfect for my purposes.

Malloc/calloc also has the advantage over allocating on the stack of allowing me to declare the size using a variable.

Patrick McDonald
  • 64,141
  • 14
  • 108
  • 120
  • 13
    I read "stack overflow exception" and thought to myself "...? is something wrong with the site?" Clearly I spend way too much time here :-/ – David Z Feb 21 '09 at 02:27
  • 5
    I'm pretty sure this type of question must have come up previously on this site, but searching for "stack overflow" is no use whatsoever – Patrick McDonald Feb 21 '09 at 02:33
  • 4
    i think every single C programmer ends up wasting a lot of their time figuring out this problem for the first time.. – MahlerFive Feb 21 '09 at 03:20
  • 2
    Turbo C++ is a 16-bit application which means that it uses memory segmentation, each segment is 64KB in size so no structure can be larger than this number, and the total memory usage is maxed at 640KB (1MB or more with some extended memory manager). Why do you need to use such a more-than-20-year-old compiler? – phuclv Oct 28 '13 at 03:33
  • I just needed a free C compiler at the time for Windows and it seemed to compile the examples I tried from a 25-year-old book. What free compiler would you recommend now? – Patrick McDonald Oct 29 '13 at 10:31
  • @MahlerFive, you have given me hope! – hat May 30 '18 at 16:08
  • 1
    By now hopefully you have discovered GCC. Among other places It comes bundled with the _[Code::Blocks](http://www.codeblocks.org/downloads/26)_ IDE. – ryyker Aug 21 '19 at 12:11
  • Related: C++ canonical Q&A answer that suggests new/delete or std::vector for the same problem: [Segmentation fault on large array sizes](https://stackoverflow.com/q/1847789) – Peter Cordes Nov 05 '21 at 04:23
  • [Is there a max array length limit in C++](https://stackoverflow.com/q/216259/14065) – Martin York Sep 15 '22 at 04:04

8 Answers8

65

Your array is way too big to fit into the stack, consider using the heap:

int *sieve = malloc(2000000 * sizeof(*sieve));

If you really want to change the stack size, take a look at this document.

Tip: - Don't forget to free your dynamically allocated memory when it's no-longer needed.

Patrick McDonald
  • 64,141
  • 14
  • 108
  • 120
arul
  • 13,998
  • 1
  • 57
  • 77
  • 24
    As this is C, you need not (and in fact, should not) cast the return value of malloc. – aib Feb 23 '09 at 02:19
  • 1
    Why wouldn't you cast the result of malloc? Wouldn't you have to cast it from void* in order to do much of anything with it? –  Feb 27 '09 at 16:19
  • 5
    @yodaj007: You don't need to cast it explicitly. Since the assigned variable is also of a pointer type, the assignment performs an implicit conversion. – jweyrich Feb 10 '11 at 17:45
  • 4
    @Amy Read this: ["Do I cast the result of `malloc`?"](http://stackoverflow.com/questions/605845/do-i-cast-the-result-of-malloc?s=1|8.2768). It explains several reasons why *not* to cast `malloc` (or any of the other memory allocation functions) in C. – WhozCraig Aug 26 '15 at 17:11
  • Related: C++ canonical Q&A answer that suggests new/delete or std::vector for the same problem: [Segmentation fault on large array sizes](https://stackoverflow.com/q/1847789) – Peter Cordes Nov 05 '21 at 04:22
15

There are 3 ways:

  1. Allocate array on heap - use malloc(), as other posters suggested. Do not forget to free() it (although for main() it is not that important - OS will clean up memory for you on program termination).
  2. Declare the array on unit level - it will be allocated in data segment and visible for everybody (adding static to declaration will limit the visibility to unit).
  3. Declare your array as static - in this case it will be allocated in data segment, but visible only in main().
qrdl
  • 34,062
  • 14
  • 56
  • 86
  • 1
    I'd just make it static: `main()` should only be called once, so there are no pitfalls; no need for `malloc()` here... – Christoph Feb 21 '09 at 10:58
1

That's about 7MB of stack space. In visual studio you would use /STACK:###,### to reflect the size you want. If you truely want a huge stack (could be a good reason, using LISP or something :), even the heap is limited to small'sh allocations before forcing you to use VirtualAlloc), you may also want to set your PE to build with /LARGEADDRESSAAWARE (Visual Studio's linker again), but this configure's your PE header to allow your compiled binary to address the full 4GB of 32'bit address space (if running in a WOW64). If building truely massive binaries, you would also typically need to configure /bigobj as an additional linker paramerter.

And if you still need more space, you can radically violate convention by using something simular to (again MSVC's link) /merge:, which will allow you to pack one section into another, so you can use every single byte for a single shared code/data section. Naturally you would also need to configure the SECTIONS permissions in a def file or with #pgrama.

RandomNickName42
  • 5,923
  • 1
  • 36
  • 35
1

Use malloc. All check the return type is not null, if it is null then your system simply doesn't have enought memory to fit that many values.

0

Your array is huge.

It's possible that your machine or OS don't have or want to allocate so much memory.


If you absolutely need an enormous array, you can try to allocate it dynamically (using malloc(...)), but then you're at risk of leaking memory. Don't forget to free the memory.

The advantage of malloc is that it tries to allocate memory on the heap instead of the stack (therefore you won't get a stack overflow).

You can check the value that malloc returns to see if the allocation succeeded or failed. If it fails, just try to malloc a smaller array.


Another option would be to use a different data structure that can be resized on the fly (like a linked list). Wether this option is good depends on what you are going to do with the data.

Yet another option would be to store things in a file, streaming data on the fly. This approach is the slowest.

If you go for storage on the hard drive, you might as well use an existing library (for databases)

Ivan Rubinson
  • 3,001
  • 4
  • 19
  • 48
0

As Turbo C/C++ is 16 bit compiler int datatype consumes about 2 bytes. 2bytes*2000000=40,00,000 bytes=3.8147MB space.

The auto variables of a function is stored in stack and it caused the overflow of the stack memory. Instead use the data memory [using static or global variable] or the dynamic heap memory [using the malloc/calloc] for creating the required memory as per the availability of the processor memory mapping.

Arun Chettoor
  • 1,021
  • 1
  • 12
  • 17
0

You would be better off allocating it on the heap, not the stack. something like

int main(int argc, char* argv[])
{
    int * sieve;
    sieve = malloc(20000);
    return 0;
}
Cogsy
  • 5,584
  • 4
  • 35
  • 47
-1

Is there some reason why you can't use alloca() to allocate the space you need on the stack frame based on how big the object really needs to be?

If you do that, and still bust the stack, put it in allocated heap. I highly recommend NOT declaring it as static in main() and putting it in the data segment.

If it really has to be that big and your program can't allocate it on the heap, your program really has no business running on that type of machine to begin with.

What (exactly) are you trying to accomplish?

Tim Post
  • 33,371
  • 15
  • 110
  • 174
  • I am using problems from ProjectEuler.net to learn C, and am implementing the Sieve of Eratosthenes algorithm, so it does have to be that big. malloc works fine for my purposes though – Patrick McDonald Feb 21 '09 at 20:10