Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

58 questions
47
votes
2 answers

How to un-approve github review after new commits automatically

Once a pull request is approved, if there are further commits: The Pull request should go to un-approved state automatically. Can this be done?
Anurag
  • 956
  • 2
  • 8
  • 21
17
votes
2 answers

Require Github PR approvals from multiple groups

I'm using the codeowners file to require PR approvals before they can be merged. What I'd like to do is: Require all PRs to have at least one approval from a group of code owners (engineers) Require all PRs to have at least one approval from a…
Brady Dowling
  • 4,920
  • 3
  • 32
  • 62
12
votes
0 answers

Viewing/Recovering pending code reviews in Github

When I start a code review, I can add multiple comments with a 'pending' status review and then submit them all at once instead of one-by-one. If I close the review and come back to it, those pending comments are saved, but it requires me going back…
Bricky
  • 2,572
  • 14
  • 30
12
votes
1 answer

How to request a code review on a committed master branch within GitHub?

I have read postings and performed code reviews on pull requests, for example: "How to create and review a GitHub pull request" GitHub Question: You (as a solo contributor) have been working on a body of code you have been committing to GitHub for…
Jeff
  • 1,917
  • 1
  • 25
  • 43
10
votes
2 answers

github: initiate code review without pull request?

it is a bad way to do code reviews after pull request has been initiated. sometimes we want to do code reviews before the whole thing is ready for integration. is there any tools out there that will allow code review without pull request? I prefer…
user2584960
  • 645
  • 1
  • 6
  • 20
6
votes
2 answers

How to see all your code reviews on github

There's a way to filter all my code reviews on github? I tried to follow docs, go to pull requests and then click on 'Review Requests', but i wasn't able to find a way to filter the code reviews i've done and see if there was any update on my…
Rafo
  • 511
  • 3
  • 17
6
votes
1 answer

git mv and changes and similarity index

When a file is renamed with git mv, the commit will show rename from and rename to, and in pull request shows the same, which is good. But when a file is git mved then changed, it looks there is a certain threshold that when number of lines changed…
fluter
  • 13,238
  • 8
  • 62
  • 100
5
votes
1 answer

How to review git pull requests (hosted on bitbucket) in intelliJ?

How can I review the git pull requests in intelliJ Idea (2018.3) and check the compile time, test run impact and other IDE features before approving or rejecting?
joonpradeep
  • 61
  • 1
  • 5
4
votes
1 answer

How do I review an entire codebase on github?

I would like to review all of the code in a single branch of a git repo on GitHub. (I am a professor, and the code is part of a student's thesis.) Any single commit affects only a small portion of the code. How can I perform a review that allows me…
Ellen Spertus
  • 6,576
  • 9
  • 50
  • 101
4
votes
1 answer

How to review pull requests revisions?

Let's say Joe is working on a big task. He submits an initial revision of his work in a big PR with 20 commits. Now other developers spend a long time reviewing that PR and ask for a few changes/fixes. Joe now amends his commits with the requested…
Juan
  • 53
  • 1
  • 4
4
votes
1 answer

Is it possible to get all my GitHub code review comments?

GitHub provides quite a convenient API (REST, v3) to see everything on repository level. To see one's comments on code review, I need to know which repositories were reviewed by him/her and crawl all PRs in these repositories. However, sometimes I…
Ilya Palachev
  • 274
  • 1
  • 2
  • 16
4
votes
2 answers

GitHub pull request reviews line comments behaviour

Recently GitHub introduced some new features including Pull Request Reviews. In the past, line comments in Pull Requests would collapse like this after the line was changed in further commits: Since the launch of the new feature, line comments no…
rink.attendant.6
  • 44,500
  • 61
  • 101
  • 156
3
votes
1 answer

Internal review before raising PR

Background: The GitHub belongs to the client. We have some newbies in the team, who sometimes miss basic naming convention and other coding protocols. So, if any senior wants to review internally there is no other way but to create a PR. But then…
paul
  • 4,333
  • 16
  • 71
  • 144
3
votes
2 answers

Making changes to branch after code review in git

I have a branch feature/my-changes which I have made changes to. I pushed these changes, created a pull request, and have gotten feedback on my changes through a code review. My question is: Now that I see the changes I need to make in github (from…
Isaac Perez
  • 570
  • 2
  • 15
  • 31
3
votes
1 answer

How to approve a review on github after a review that requests changes?

I reviewed a pull request on github and requested changes. They made and pushed the changes. Now I can't find a button to re-review and say "approve." Where is it? I also looked at the docs. No luck.
dfrankow
  • 20,191
  • 41
  • 152
  • 214
1
2 3 4